Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve FieldIndexer setting in yurt-manager #1834

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

2456868764
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

improve FieldIndexer setting in yurt-manager

Which issue(s) this PR fixes:

Fixes #1794

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@2456868764: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

improve FieldIndexer setting in yurt-manager

Which issue(s) this PR fixes:

Fixes #1794

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 2456868764
To complete the pull request process, please assign lavenderqaq
You can assign the PR to them by writing /assign @lavenderqaq in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c54adc4) 52.11% compared to head (2aee8dd) 52.18%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1834      +/-   ##
==========================================
+ Coverage   52.11%   52.18%   +0.07%     
==========================================
  Files         172      172              
  Lines       20836    20824      -12     
==========================================
+ Hits        10858    10868      +10     
+ Misses       9016     8995      -21     
+ Partials      962      961       -1     
Flag Coverage Δ
unittests 52.18% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openyurt-bot openyurt-bot added size/S size/S 10-29 and removed size/M size/M: 30-99 labels Nov 29, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openyurt-bot openyurt-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Nov 30, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Dec 1, 2023
@rambohe-ch rambohe-ch merged commit da81373 into openyurtio:master Dec 1, 2023
14 of 15 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
* improve FieldIndexer setting in yurt-manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]improve FieldIndexer setting in yurt-manager
3 participants