-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve FieldIndexer setting in yurt-manager #1834
improve FieldIndexer setting in yurt-manager #1834
Conversation
@2456868764: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 2456868764 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1834 +/- ##
==========================================
+ Coverage 52.11% 52.18% +0.07%
==========================================
Files 172 172
Lines 20836 20824 -12
==========================================
+ Hits 10858 10868 +10
+ Misses 9016 8995 -21
+ Partials 962 961 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…abled or not when register field indexers
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/lgtm |
* improve FieldIndexer setting in yurt-manager
What type of PR is this?
What this PR does / why we need it:
improve FieldIndexer setting in yurt-manager
Which issue(s) this PR fixes:
Fixes #1794
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note